Ensure that a PushProvider is available on a device before using it.

[bmarty]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Ensure that a PushProvider is available on a device before using it.
It help to fallback to UnifiedPush (if available) if the PlayServices are not installed on the device.

Motivation and context

Let the device fallback to UnifiedPush if the PlayServices is not available on the device, even if installed from the PlayStore.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[codecov]

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (4bbaced) 70.00% compared to head (54f3f8d) 69.95%.
Report is 11 commits behind head on develop.

Files	Patch %	Lines
...ies/pushproviders/firebase/FirebasePushProvider.kt	0.00%	8 Missing ⚠️
...s/pushproviders/unifiedpush/UnifiedPushProvider.kt	0.00%	7 Missing ⚠️
.../android/libraries/push/impl/DefaultPushService.kt	0.00%	3 Missing ⚠️
...c/main/kotlin/io/element/android/x/di/AppModule.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2248      +/-   ##
===========================================
- Coverage    70.00%   69.95%   -0.05%     
===========================================
  Files         1335     1335              
  Lines        32632    32656      +24     
  Branches      6788     6791       +3     
===========================================
+ Hits         22843    22844       +1     
- Misses        6512     6535      +23     
  Partials      3277     3277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/d1cTzp

[jmartinesp]

The PR LGTM, thanks.

Let the device fallback to UnifiedPush if the PlayServices is not available on the device, even if installed from the PlayStore.

Just curious, is that even possible?

[spaetz]

Just curious, is that even possible?

Absolutely. For one thing, there are alternative store applications (eg Aurora store) which install apks from the play store without having any Google Framework installed.
Alternatively, one can enable all Play stuff, install whatever one needs and deactivate all play stuff subsequently.

...or so I have heard from a friend 😜

[K4LCIFER]

Let the device fallback to UnifiedPush if the PlayServices is not available on the device, even if installed from the PlayStore.

Does this mean that one cannot choose to use UnifiedPush from within the app? One can only use UnifiedPush if, somehow, PlayServices is made unavailable?

[bmarty]

Does this mean that one cannot choose to use UnifiedPush from within the app? One can only use UnifiedPush if, somehow, PlayServices is made unavailable?

Yes. There is no in app selector if both providers are available.
I you want to ensure that UnifiedPush is used, a solution could be to install the application from F-Droid when it will be available.

[K4LCIFER]

Yes. There is no in app selector if both providers are available.

Is there a plan to add one in the future?