Disable trace logs for read receipts #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
changed the title
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2511 +/- ##
===========================================
- Coverage 72.97% 72.97% -0.01%
===========================================
Files 1394 1394
Lines 33517 33515 -2
Branches 6493 6493
===========================================
- Hits 24459 24457 -2
Misses 5672 5672
Partials 3386 3386 ☔ View full report in Codecov by Sentry. |
bmarty
reviewed
Mar 8, 2024
| @@ -67,7 +66,6 @@ enum class Target(open val filter: String) { | |||
| MATRIX_SDK_SLIDING_SYNC("matrix_sdk::sliding_sync"), | |||
| MATRIX_SDK_BASE_SLIDING_SYNC("matrix_sdk_base::sliding_sync"), | |||
| MATRIX_SDK_UI_TIMELINE("matrix_sdk_ui::timeline"), | |||
| MATRIX_SDK_BASE_READ_RECEIPTS("matrix_sdk_base::read_receipts"), | |||
There was a problem hiding this comment.
We could eventually keep this line to be able to manually tweak the tracing configuration from the app.
Read receipts have been considered quite stable over the last few weeks, so there's no need to keep the trace level for the associated logs for the time being.
bnjbvr
force-pushed
the
bnjbvr/disable-special-log-level-for-read-receipts
branch
from
a4a4041
to
33a039d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read receipts have been considered quite stable over the last few weeks, so there's no need to keep the trace level for the associated logs for the time being.
Signed-off-by: Benjamin Bouvier public@benj.me