-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sdk API to build permalinks #2708
Conversation
…rmalinks for user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One remark otherwise LGTM
|
||
fun onShareRoom() { | ||
this.onShareRoom(context) | ||
coroutineScope.onShareRoom(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use scope of the node instead of the view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, done
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2708 +/- ##
========================================
Coverage 73.13% 73.13%
========================================
Files 1478 1478
Lines 35709 35707 -2
Branches 6862 6862
========================================
+ Hits 26114 26115 +1
+ Misses 6043 6040 -3
Partials 3552 3552 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Type of change
Content
Use SDK API to build permalinks
Motivation and context
Share code with iOS.
Screenshots / GIFs
Tests
Tested devices
Checklist