Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sdk API to build permalinks #2708

Merged
merged 5 commits into from
Apr 15, 2024
Merged

Use sdk API to build permalinks #2708

merged 5 commits into from
Apr 15, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Apr 15, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Use SDK API to build permalinks

Motivation and context

Share code with iOS.

Screenshots / GIFs

Tests

  • Attempt to create room permalink or user permalink.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner April 15, 2024 14:41
@bmarty bmarty requested review from ganfra and removed request for a team April 15, 2024 14:41
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark otherwise LGTM


fun onShareRoom() {
this.onShareRoom(context)
coroutineScope.onShareRoom(context)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use scope of the node instead of the view?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, done

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.13%. Comparing base (7b14a0e) to head (9fcb880).

Files Patch % Lines
...droid/libraries/matrix/test/room/FakeMatrixRoom.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2708   +/-   ##
========================================
  Coverage    73.13%   73.13%           
========================================
  Files         1478     1478           
  Lines        35709    35707    -2     
  Branches      6862     6862           
========================================
+ Hits         26114    26115    +1     
+ Misses        6043     6040    -3     
  Partials      3552     3552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/kYohHQ

@bmarty bmarty merged commit 89d2f43 into develop Apr 15, 2024
16 checks passed
@bmarty bmarty deleted the feature/bma/sdkPermalink branch April 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants