-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse permalink using parseMatrixEntityFrom
from the SDK
#2709
Conversation
Create new PermalinkData type for link to Events. Keep matrixToConverter for now to first convert to matrix.to link. At some point it may be done by the SDK. Remove parse(Uri)
) : EventLink | ||
|
||
data class EventIdAliasLink( | ||
val roomAlias: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create RoomAlias
and RoomOrAliasId
value classes? I really think it'll be easier to manage like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maybe, but I thought you created it?
And I am pretty sure that when we build a permalink for an event, the roomId is used, even if a room Alias is availalbe. The main reason is that roomId are immutable (module room upgrade...), and aliases can change.
Can this be handled separately?
Quality Gate passedIssues Measures |
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2709 +/- ##
===========================================
- Coverage 73.13% 73.11% -0.03%
===========================================
Files 1478 1478
Lines 35707 35712 +5
Branches 6862 6860 -2
===========================================
- Hits 26115 26111 -4
- Misses 6040 6049 +9
Partials 3552 3552 ☔ View full report in Codecov by Sentry. |
Type of change
Content
Create new PermalinkData type for link to Events.
Keep matrixToConverter for now to first convert to matrix.to link. At some point it may be done by the SDK.
Remove API
PermalinkParser.parse(Uri)
, not really necessary anymore.Motivation and context
Use common code from the SDK.
Screenshots / GIFs
Tests
Tested devices
Checklist