Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for Android per-app language preferences #2795

Merged
merged 2 commits into from
May 6, 2024
Merged

Enable support for Android per-app language preferences #2795

merged 2 commits into from
May 6, 2024

Conversation

tonkku107
Copy link
Contributor

@tonkku107 tonkku107 commented May 4, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR does the few changes necessary to support this system feature on Android 13 and newer devices. This does not add in-app language settings or a method for Android 12 and older users to set a per-app language, but this can be done later using androidx.appcompat APIs.

Motivation and context

Users would like to set a different language than their system default for Element X. This PR would at least allow users with Android 13 or newer to use their system settings to change the language to their preferences until (and after) an in-app UI is created.

Screenshots / GIFs

image

Tests

  • Installed debug build
  • Opened app info
  • Checked that the language settings existed
  • Checked that switching to another language (for example German) also reflected to a change in language in-app
  • Made sure the app still works on API 23, and nothing has changed

Tested devices

  • Physical
  • Emulator
  • OS version(s): 15 (Beta 1.2), 6

Checklist

I would like to sign-off privately.

@tonkku107 tonkku107 requested a review from a team as a code owner May 4, 2024 21:23
@tonkku107 tonkku107 requested review from jmartinesp and removed request for a team May 4, 2024 21:23
Copy link
Contributor

github-actions bot commented May 4, 2024

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • Your branch should be based on origin/develop, at least when it was created.
  • There is a changelog entry in the changelog.d folder with the Towncrier format.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@jmartinesp jmartinesp added the Z-Community-PR Issue is solved by a community member's PR label May 6, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is something that would have been useful to implement to verify issues in different languages but it was never a priority to build, so it's perfect that's done in an external contribution!

@jmartinesp jmartinesp merged commit 86838e7 into element-hq:develop May 6, 2024
13 of 14 checks passed
@tonkku107 tonkku107 mentioned this pull request May 15, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants