Session falsely displayed as 'verified' with no internet connection

[jmartinesp]

Remove the need to wait for isReady for SessionVerificationService.canVerifySessionFlow to fix this.

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Remove the need to check whether the sliding sync state is running to have a 'needs to verify' state.

Motivation and context

When no internet connection was found or the sliding sync process wasn't running, sessions were falsely being displayed in UI as verified although they were unverified.

Screenshots / GIFs

auto-verified.mp4

Tests

• Log into an account.
• When getting into the 'verify your session' screen, disable every source of internet connection.
• If it doesn't get into the 'device verified' screen, it's working.

I couldn't find any side effects, but it might be worth it double checking those.

Tested devices

• Physical
• Emulator
• OS version(s): 13

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EMibmY

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (5d8cc80) to head (e50b358).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2884      +/-   ##
===========================================
- Coverage    74.30%   74.30%   -0.01%     
===========================================
  Files         1530     1530              
  Lines        36524    36521       -3     
  Branches      7054     7054              
===========================================
- Hits         27140    27137       -3     
  Misses        5698     5698              
  Partials      3686     3686              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

OK, but as you said, it's hard to see if they can have some side effects...

[bmarty]

Maybe take the opportunity to rename canVerifySessionFlow to mustVerifySessionFlow or needToVerifySessionFlow for clarity?

Also SessionVerificationService.isReady is not used externally, so maybe remove it from the interface?

[bmarty]

I understand that if the verificationStatus get the value SessionVerifiedStatus.NotVerified, it means that the sliding sync is ready, but I am not 100% sure.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud