Add public device keys to rageshakes

[BillCarsonFr]

Fixes #2857

The MatrixClientProvider is now injected into DefaultBugReporter, to allow to access to new properties exposed in the EncrytionService (deviceCurve25519(), deviceed25519())

I added a new test to assert the form data part added in the request by the BugReporter

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Motivation and context

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/wkVRG5

[bmarty]

Thanks for the new test!
I think EXPECTED_NUMBER_OF_PROGRESS_VALUE will have to be changed to 18

[bmarty]

sessionData?.userId is guaranteed to be a valid userId, so to simplify, I would change line 148 from
val userId = sessionData?.userId ?: "undefined"
to
val userId = sessionData?.userId?.let { UserId(it) }

and use ?: "undefined" at line 148.

Please be aware that the value can still be null (user can send bug report before having a session.

[BillCarsonFr]

Updated

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.25%. Comparing base (3f46544) to head (141e835).
Report is 10 commits behind head on develop.

Files	Patch %	Lines
...ures/rageshake/impl/reporter/DefaultBugReporter.kt	60.00%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2893      +/-   ##
===========================================
+ Coverage    75.23%   75.25%   +0.01%     
===========================================
  Files         1550     1550              
  Lines        36954    36966      +12     
  Branches      7152     7156       +4     
===========================================
+ Hits         27803    27817      +14     
+ Misses        5415     5412       -3     
- Partials      3736     3737       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BillCarsonFr]

Thanks for the new test! I think EXPECTED_NUMBER_OF_PROGRESS_VALUE will have to be changed to 18

The existing test was happy because we don't add that part if the keys are null. So I added the listener in the other test to ensure that we have one more thing reported

[bmarty]

Thanks for the update!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud