Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text composer is cleared when leaving timeline screen #2898

Closed
noantiq opened this issue May 22, 2024 · 2 comments · Fixed by #2902
Closed

Text composer is cleared when leaving timeline screen #2898

noantiq opened this issue May 22, 2024 · 2 comments · Fixed by #2902
Assignees
Labels
A-Composer O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@noantiq
Copy link

noantiq commented May 22, 2024

Steps to reproduce

  1. Open a room
  2. type a message but don't send it yet
  3. leave the screen (eg. by navigating back to the room list, opening the room's description by clicking it's title or simply sending a picture)

Outcome

What did you expect?

My message draft is still there and I can continue writing my message or send it.

What happened instead?

The composer is cleared, my message draft is gone.

With a version preceding the introduction of the new plain text editor (yesterday's nightly for example), the composer wasn't cleared when opening the room description or sending a picture. It was cleared when navigating back to the room list in previous versions as well, which was annoying enough.

Your phone model

No response

Operating system version

No response

Application version and app store

Today's nightly (2024-05-22)

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

@noantiq noantiq added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label May 22, 2024
@frebib
Copy link
Contributor

frebib commented May 22, 2024

Duplicate of #2869

Edit: although the loss of the draft when opening the room info is a regression

@jmartinesp
Copy link
Member

Yeah, drafts are not supported yet, but keeping the text while seeing the room info and other sub-screens should be working. However, the compose Saver wasn't implemented and the text is forgotten when the screen is no longer visible.

@jmartinesp jmartinesp added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Composer labels May 23, 2024
@jmartinesp jmartinesp self-assigned this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants