-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hidden developer settings in release builds too #3020
Add hidden developer settings in release builds too #3020
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
19b852c
to
bead18a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3020 +/- ##
========================================
Coverage 75.78% 75.79%
========================================
Files 1611 1613 +2
Lines 38101 38124 +23
Branches 7362 7367 +5
========================================
+ Hits 28876 28895 +19
- Misses 5373 5374 +1
- Partials 3852 3855 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some late remarks, feel free to ignore :)
package io.element.android.features.preferences.impl.root | ||
|
||
sealed interface PreferencesRootEvents { | ||
data object EnableDeveloperSettingsClicked : PreferencesRootEvents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one late remark, I would name this Event OnFooterClick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it to OnVersionInfoClick
since it's a bit more descriptive.
assertThat(loadedState.showDeveloperSettings).isFalse() | ||
|
||
repeat(times = ShowDeveloperSettingsProvider.DEVELOPER_SETTINGS_COUNTER) { | ||
loadedState.eventSink(PreferencesRootEvents.EnableDeveloperSettingsClicked) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add at the beginning of the repeat block:
assertThat(awaitItem().showDeveloperSettings).isFalse()
Quality Gate passedIssues Measures |
Type of change
Content
Adds developer settings for release apps too:
Motivation and context
Helping users using release builds debug some issues.
Tests
Tested devices
Checklist