Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you take a photo in Element X, it doesn't add an extension to the file name causing improper rendering on Web/Desktop #3990

Open
Twi1ightSparkle opened this issue Dec 3, 2024 · 3 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@Twi1ightSparkle
Copy link

Steps to reproduce

  • In Element X click +, then Take photo
  • Optionally add a caption
  • Send

Outcome

What did you expect?

Properly formatted message

What happened instead?

Because of element-hq/element-web#11424, Element Web 1.11.87 doesn't render the image and instead shows it as a file attachment.

screenshot_2024-12-03T17-01-02Z

It also set's the caption as the file name if you try downloading the attachment

screenshot_2024-12-03T17-01-26Z

Element X renders both properly

1000000286

I'll attach the event content to the rageshake. However, looking at the diff, EX doesn't add a file extension to the filename, this might be the reason?

Element Android 1.6.20 also renders both images, but without captions.

Element X iOS 0.7.3 doesn't have this issue, photos taken from within the EX app there works.

Your phone model

Samsung Galaxy A15

Operating system version

Android 14

Application version and app store

Element X 0.7.3

Homeserver

Sent from element.io to matrix.org

Will you send logs?

Yes

Are you willing to provide a PR?

No

@Twi1ightSparkle Twi1ightSparkle added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 3, 2024
@frebib
Copy link
Contributor

frebib commented Dec 3, 2024

This is an Element Web bug/regression?

@Twi1ightSparkle
Copy link
Author

This is an Element Web bug/regression?

Not looked into this more than inspecting the event content, but I suspect it's a combination of EXA needing to add a file extension to the file name and EW should be trying to figure out what a file is based on metadata, not just file name extension (element-hq/element-web#11424)

@spaetz
Copy link

spaetz commented Dec 4, 2024

Should be fixed by #3903 (probably in the next release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants