Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Mute" shortcut icon and a "Notifications" section in the room details screen #506

Closed
6 tasks done
Tracked by #1075
giomfo opened this issue Jun 1, 2023 · 1 comment
Closed
6 tasks done
Tracked by #1075
Assignees
Labels
A-Notifications T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@giomfo
Copy link
Member

giomfo commented Jun 1, 2023

Definition

The current room notifications setting may have 2 origins:

  • "Default": the setting is only related to the global push rules defined at the account level
  • "Custom": the setting is related to a push rule created at the room level (it overrides the default)

Description

  • Add a "Mute" shortcut icon
    • This icon tells if the room is muted or not
    • Here are the expected behavior when the user clicks on it:
Current mode New mode Actions
Unmute (default) Mute (custom) Create a custom rule to mute this room
Unmute (custom) Mute (custom) Delete the custom rule and create a new one to mute this room
Mute (default) Unmute (custom) Create a custom rule to receive all messages (This use case should not happen for the moment)
Mute (custom) Unmute Delete the custom rule (Create a custom rule to receive all messages, if the default setting is Mute, which should not happen for the moment)
  • Add a "Notifications" section
    • Display "Default" is the current room notification setting is the default
    • Display the resulting mode in case of a custom setting ("All" / "Mentions"/ "Mute")

Suggested design:

image

Sign-offs

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion
@yostyle yostyle transferred this issue from element-hq/element-meta Jun 1, 2023
@giomfo giomfo added T-Task Refactoring, enabling or disabling functionality, other engineering tasks A-Notifications labels Jun 1, 2023
@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Oct 10, 2023
@amshakal
Copy link

It works! It just takes a few seconds..I am guessing it's because the request goes to the server

@langleyd langleyd assigned langleyd and unassigned yostyle Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Development

No branches or pull requests

5 participants