Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When verifying a device using emoji, the text is confusing #879

Closed
anoadragon453 opened this issue Jul 14, 2023 · 7 comments · Fixed by #1751
Closed

When verifying a device using emoji, the text is confusing #879

anoadragon453 opened this issue Jul 14, 2023 · 7 comments · Fixed by #1751
Labels
A-E2EE-Cross-Signing good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish

Comments

@anoadragon453
Copy link
Member

Steps to reproduce

Screenshot_20230714-152730

On the screen just before you start verifying emoji, the text says: "Confirm that the emojis below match those shown on your other session".

There are no emojis below. Instead, they are shown on the next screen once the other device has accepted to also show emojis.

But a quick question: Why does this screen even exist? What is the user going to do here other than click "Start"? Can we just skip it instead?

Outcome

.

Your phone model

Google Pixel 4a 5G

Operating system version

Android 13.0

Application version and app store

Commit 1c15db2

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

No

@anoadragon453 anoadragon453 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jul 14, 2023
@bmarty
Copy link
Member

bmarty commented Jul 17, 2023

Thanks for reporting. I have never seen the screen in that state, maybe because network was fast last time I verified a session.

@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-E2EE-Cross-Signing labels Jul 17, 2023
@anoadragon453
Copy link
Member Author

My phone stayed on this screen until I accepted the verification on my other session, regardless of network speed.

@bmarty
Copy link
Member

bmarty commented Jul 17, 2023

Yes, true, I can repro it. I was too fast to accept on the other side :)

@bmarty bmarty self-assigned this Jul 19, 2023
@bmarty
Copy link
Member

bmarty commented Jul 19, 2023

I was able to repro this morning, but when I wanted to take some screenshots, I cannot repro anymore. Will try again later.

@bmarty bmarty removed their assignment Aug 28, 2023
@jmartinesp
Copy link
Member

Just to confirm: this also happens on iOS, which was used as a base for this feature. At this point we are waiting for either us or the other session which received our request to start the verification process. If we don't want this, we need to either:

  1. Change the text to something more descriptive ("Press Start to begin the verification process" or something similar).
  2. Automatically start the verification process from the app without user interaction, skipping this screen. I'd have to double check if this could affect the verification retry flow in some way.

In any case, I think this issue needs some product/design feedback.

@jmartinesp jmartinesp added X-Needs-Design X-Needs-Product Issue needs input from Product team labels Aug 29, 2023
@kittykat
Copy link
Contributor

kittykat commented Oct 12, 2023

We can remove the text altogether for now. I think we can just have "Compare emojis" and the "Start" button at the bottom to trigger.

Alternatively, we just use the text from web: "Compare a unique set of emoji"

@kittykat kittykat added Z-Schedule Z-Polish good first issue Good for newcomers help wanted Extra attention is needed Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ and removed X-Needs-Design X-Needs-Product Issue needs input from Product team labels Oct 12, 2023
@jmartinesp
Copy link
Member

jmartinesp commented Nov 7, 2023

@kittykat I went with 'Compare a unique set of emojis.' for the text in the end, leaving the screen with just the title felt really weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE-Cross-Signing good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants