Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installed as a macOS app, EXI intercepts EC URLs, but can't render them. #1794

Closed
ara4n opened this issue Sep 25, 2023 · 2 comments · Fixed by #1801
Closed

When installed as a macOS app, EXI intercepts EC URLs, but can't render them. #1794

ara4n opened this issue Sep 25, 2023 · 2 comments · Fixed by #1801
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Sep 25, 2023

Steps to reproduce

  1. Install EXI as a macOS app
  2. Click on an call.element.io link in your calendar
  3. It opens in EXI, which say "WebRTC unavailable"

Outcome

What did you expect?

Either EX should work on macOS (given Safari supports WebRTC!) - or we shouldn't try to intercept EC URLs on macOS until it does.

What happened instead?

Unexpected breakage. Given we're not stopping users from installing EXI on macOS (and nor should we, as it works really very well, especially relative to the lumbering beast that is EW), i think we should at least support basic use cases (e.g. not breaking EC calls)

Your phone model

Macbook Pro :P

Operating system version

macOS Ventura 13.6 (22G120)

Application version

393

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Sep 25, 2023
@ara4n
Copy link
Member Author

ara4n commented Sep 25, 2023

Screenshot 2023-09-25 at 17 18 03

this is the 10th time i've seen this today :D

@stefanceriu
Copy link
Member

Either EX should work on macOS (given Safari supports WebRTC!)

Unfortunately that's not the case, navigator.mediaDevices isn't available on iOS apps running on Apple Silicon or on Mac Catalyst.

we shouldn't try to intercept EC URLs on macOS until it does.

This is not an option either as we can't tell universal links to ignore just the Mac app.

The only option is to make it redirect to your default browser, but the Mac app will still be launched first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants