Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump posthog SDK version to 3.2.0 #2788

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

BillCarsonFr
Copy link
Member

Bump posthog version to 3.2.0.
We were using a quite old posthog sdk. Updating to the new one mainly because it now support sessions. Allow us to have a per device view instead of only unique users that is merging events from all the devices of the same user.
Element X Android is already using posthog 3.x

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner May 6, 2024 08:13
@BillCarsonFr BillCarsonFr requested review from pixlwave and removed request for a team May 6, 2024 08:13
Copy link

github-actions bot commented May 6, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against e1499cb

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.35%. Comparing base (c398338) to head (1afc242).

❗ Current head 1afc242 differs from pull request most recent head e1499cb. Consider uploading reports for the commit e1499cb to get more accurate results

Files Patch % Lines
...es/Services/Analytics/PostHogAnalyticsClient.swift 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2788      +/-   ##
===========================================
+ Coverage    73.32%   73.35%   +0.03%     
===========================================
  Files          597      597              
  Lines        42686    42696      +10     
===========================================
+ Hits         31298    31320      +22     
+ Misses       11388    11376      -12     
Flag Coverage Δ
unittests 62.27% <83.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 enabled auto-merge (squash) May 6, 2024 14:41
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit 176abd5 into develop May 6, 2024
5 checks passed
@Velin92 Velin92 deleted the valere/bump_posthog_sdk_version branch May 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants