Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type for /publicRooms limit #10304

Open
matrixbot opened this issue Dec 18, 2023 · 0 comments
Open

Wrong type for /publicRooms limit #10304

matrixbot opened this issue Dec 18, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 18, 2023

This issue has been migrated from #10304.


According to https://spec.matrix.org/unstable/server-server-api/#get_matrixfederationv1publicrooms it should be an integer, but here it is stringified:

https://github.com/matrix-org/synapse/blob/a7a37437bc0364d6cde93f3ec264e06ed6324068/synapse/federation/transport/client.py#L425

Conduit errors when the parameter is a string.

@matrixbot matrixbot changed the title Dummy issue Wrong type for /publicRooms limit Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant