Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room membership endpoints (/join, /leave, /forget) accept requests with malformed or no bodies #13388

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

Room membership endpoints (/join, /leave, /forget) accept requests with malformed or no bodies #13388

matrixbot opened this issue Dec 20, 2023 · 0 comments
Labels
A-Spec-Compliance T-Defect

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023 •
edited
Loading

This issue has been migrated from #13388.

The following endpoints accept, and ignore, requests with bodies which are not valid JSON objects:

  • /_matrix/client/v3/join/{roomIdOrAlias}
  • /_matrix/client/v3/rooms/{roomId}/join
  • /_matrix/client/v3/rooms/{roomId}/leave

(as well as their non-v3 equivalents).

This is a spec violation, but it appears there are a number of clients that currently rely on it.
@matrixbot matrixbot changed the title Dummy issue Room membership endpoints (/join, /leave, /forget) accept requests with malformed or no bodies Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spec-Compliance T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matrixbot