Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp massaging to /createRoom #15346

Open
1 task done
matrixbot opened this issue Dec 21, 2023 · 0 comments
Open
1 task done

Add timestamp massaging to /createRoom #15346

matrixbot opened this issue Dec 21, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #15346.


As propsed by MSC3997, following in the footsteps of MSC3316's timestamp massaging query parameter for /send?ts=123, add the same thing to the /createRoom endpoint

POST /_matrix/client/v3/createRoom?ts=123

Why

When writing end-to-end tests, it's useful to have your room appear as though it was created back in time before your messages were sent and to have stable/consistent timestamps. If you start using the timestamp massaging with messages, it can appear as though those events occurred before the m.room.create and other primordial events.

So this issue, proposes being able to modify the origin_server_ts of all of the primordial room creation events.

This could also apply to other endpoints (/join, /ban) but I'm mostly concerned with the /createRoom endpoint because that's the hairy area in my Matrix Public Archive tests at the moment. And /ban, etc can be emulated with the normal /send endpoint and sending the appropriate events.

/join can only be emulated for local joins as joins against rooms the server doesn't know about doesn't work since there is no way to specify via servers`. Created MSC3998

Todo

@matrixbot matrixbot changed the title Dummy issue Add timestamp massaging to /createRoom Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant