Remove cibuildwheel pp38* skip selector
#19085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pp38*` used to be enabled, until it went EOL. Now we get the following warning as we're trying to skip a selector which is not enabled: ``` cibuildwheel: Invalid skip selector: 'pp38*'. This selector matches a group that wasn't enabled. Enable it using the `enable` option or remove this selector. This selector will have no effect. ``` Removing the skip selector silences the warning.
MadLittleMods
approved these changes
Oct 23, 2025
| # - musllinux i686: excluded to reduce number of wheels we build. | ||
| # c.f. https://github.com/matrix-org/synapse/pull/12595#discussion_r963107677 | ||
| skip = "cp38* pp38* *-musllinux_i686" | ||
| skip = "cp38* *-musllinux_i686" |
Contributor
There was a problem hiding this comment.
I have no experience with this but checking out all of the references and description, this seems fine.
And especially if you were running into problems during the release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pp38*used to be enabled, until it went EOL. Now we get the following warning as we're trying to skip a selector which is not enabled:Removing the skip selector silences the warning.
cibuildwheeldoes not include EOL'd version of PyPy in its selectors by default, so there's no need to skip it:https://github.com/pypa/cibuildwheel/blob/a6acd2a2d58327de04fb27dc4c837cdb386e7c15/cibuildwheel/selector.py#L96-L97
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.