Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Flatpak remote names from Title field #1310

Closed
isantop opened this issue May 12, 2020 · 0 comments · Fixed by #1962
Closed

Get Flatpak remote names from Title field #1310

isantop opened this issue May 12, 2020 · 0 comments · Fixed by #1962
Labels
Priority: Wishlist Not a bug. A new feature or enhancement Status: Confirmed Verified by someone other than the reporter

Comments

@isantop
Copy link
Collaborator

isantop commented May 12, 2020

Prerequisites

  • [*] I have searched open and closed issues for duplicates.

Feature

Is your feature request related to a problem? Please describe.

AppCenter displays the name of the Flatpak remote in the UI when viewing a Flatpak App. It's getting this from the name in the config, which is a cli-friendly (i.e. lowercase, no spaces) name of the remote. Flatpak also provides the xa.title field which can get a UI-Friendly display title of a remote, which would be better than using the name as it's intended for UI display to users.

Describe the solution you'd like

Use the Title field to display remote names in AppCenter

Existing work

https://github.com/pop-os/repoman uses Titles for displaying remotes to users (and falls back on the name when a title is unavailable, as it's an optional field):

image

libflatpak provides the FlatpakRemote.get_title() method to get the title if one is available.

Describe alternatives you've considered

It looks like GNOME Software hardcodes UI-Friendly names in the code (e.g. if remote_name == 'flathub': remote_name = 'Flathub'; this works, but we probably want to avoid doing that except in very extreme circumstances.

Additional context

Flatpak remote configuration docs
libflatpak FlatpakRemote docs

@cassidyjames cassidyjames added Priority: Wishlist Not a bug. A new feature or enhancement Status: Confirmed Verified by someone other than the reporter labels May 12, 2020
@cassidyjames cassidyjames changed the title AppCenter should get Flatpak remote names from the Title field. Get Flatpak remote names from Title field Jun 17, 2021
@danirabbit danirabbit moved this to Done in Flatpak Support Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Wishlist Not a bug. A new feature or enhancement Status: Confirmed Verified by someone other than the reporter
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants