Theme specific branding colors

[razzeee]

Problem

It seems like appcenter will always take the branding color without a scheme

appcenter/src/Core/Package.vala

Line 826 in f8db519

color_primary = branding.get_color (AppStream.ColorKind.PRIMARY, AppStream.ColorSchemeKind.UNKNOWN);

(I might just no be understanding vala)

Flathub apps will almost always have a scheme_preference that should be read instead. Those will look similar to the spec https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-branding

    <branding>
      <color type="primary" scheme_preference="light">#ff00ff</color>
      <color type="primary" scheme_preference="dark">#993d3d</color>
    </branding>

But you would also need to handle

    <branding>
      <color type="primary" scheme_preference="light">#ff00ff</color>
      <color type="primary">#993d3d</color>
    </branding>

And this one, that's probably already working

    <branding>
      <color type="primary">#993d3d</color>
    </branding>

If this is not done, we might run into comparability problems.

For e.g. we had an app with the following (kinda nonsensical definition)

<branding>
    <color type="primary">#f9c440</color>
    <color type="primary" scheme_preference="light">#d48e15</color>
    <color type="primary" scheme_preference="dark">#ffe16b</color>
  </branding>

Presumably cause they wanted it to work in flathub and appcenter.

ryonakano/konbucase#128 (comment)

Proposal

Parse all branding colors from appstream including the scheme_preference

Prior Art (Optional)

No response

[ausdauerer]

Hey, can i work on this issue? Thanks

[danirabbit]

@ausdauerer feel free to propose a branch! Thanks 🩷