Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "Open in Terminal Pane" item to the "Open In" menu #1408

Open
danirabbit opened this issue Jan 18, 2024 · 4 comments
Open

Move "Open in Terminal Pane" item to the "Open In" menu #1408

danirabbit opened this issue Jan 18, 2024 · 4 comments

Comments

@danirabbit
Copy link
Member

What Happened?

There is a new menu item "Open in Terminal Pane" that is outside of the "Open in" menu

Steps to Reproduce

Screenshot from 2024-01-18 10 10 09

Secondary click on a folder in the sidebar

Expected Behavior

"Open in" items should be in the "Open In" submenu :)

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@jeremypw
Copy link
Collaborator

jeremypw commented Jan 18, 2024

This is similar to e.g. Files which as a separate menuitem "Open in " for faster opening in the common case.
I would be 👎 on moving it to the submenu - it just adds another click and hunting through a submenu for little gain.

@danirabbit
Copy link
Member Author

danirabbit commented Jan 18, 2024

@jeremypw There's not really a reason why this "Open in" item is special and different from other "Open in" actions like new tab, new window, etc. If you need the fastest opening there is a keyboard shortcut :) But not having items organized with other like items is what leads to menu hunting.

The toplevel item in files is for the default activate/launch case since that's sometimes non-obvious. In code the default activate case for a folder is to expand/collapse it

@jeremypw
Copy link
Collaborator

I use that option all the time and it was irritating to have to open the submenu to get to "Open in Terminal" option. True, you have the shortcut but I still regard this internal action more important than and distinct from opening in an external app. I don't understand the comment about "default active case" - expand/collapse isn't a menu option at all. For me "Open in Terminal Pane" is probably the most used option, at least for project folders.

@jeremypw
Copy link
Collaborator

The option could be moved to the bottom of the menu I suppose, but it wouldn't be my preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants