-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/update eBook and eDocument mimetype icons #1079
Conversation
Since |
- Comic Book icon (.cbz, .cbr) - Mobipocket icon (.mobi, .azw, .azw3) - Postscript icon (.ps) - Deja Vu icon (.djvu)
b3c4f8e
to
2cc0835
Compare
Makes sense, thanks! Ok, I updated. Currently:
For Mobipocket/Amazon, currently using blank green book/ebook icon (right), could try adding text or a bookmark (left), but bookmark may make it feel like a bookmark file. So might be best to leave it blank/generic unless someone can suggest something that symbolizes Amazon/Mobi (can't use their logo of course). Edit: I also tried generic eBook with the pdf FictionBook/fb icon, added 128px. I like the green better, matches the other eBooks if the above changes go through. If green is preferred I can change the other sizes as well. Any more input would be helpful. Thanks! |
Hey thanks for looking into this! I would lean away from changing the file type icons for any formats that aren't supported out of the box. It's pretty easy for file types to get out of control trying to support absolutely every format, so we've really been slimming these down. Anything in the In fact, it would be worth probably dropping some of the filetype icons in the current master. I would be inclined to remove the fictionbook icons tbh. But if it stays, the fictionbook icon should remain orange since that's the brand color used in the fictionbook logo. Something we should test is if fallbacks in the namespace work for these For the comicbook icon I like the metaphor, but I might try to re-use the bubble shape from |
@danrabbit, What would you suggest about the other eDocument/eBook mimetypes in this PR. DejaVu and PostScript are both read by Evince. Is using the pdf/eDocument icon okay for those? Mobi/AZW are not read by default (but neither is ePub). Use the generic eBook icon or don't worry about those?
Is this an elementary convention or a standard for mimetypes? I don't know much about the naming scheme of mimetypes and the reasoning behind some of them. I've noticed some mimetype icons are provided by an app if it can only be opened with that app, For the comic icon, I tried using the name I tried this version with the I also tried an outline on the first version. However, the Personally I feel the chat bubble should be reserved for chat related icons (as it is also used for the Iridium app icon which could be confusing). Usually comic bubbles have a longer sharper tail. And the font is usually somewhat italic, with question and exclamation marks usually being bold and more italicized. Here's an example. That was kind of my rationale for the original icon. With the chat bubble and normal font it looks a little like a chat or help symbol to me. But I've been playing with it too long so my perspective might be way off. Anyway, just let me know how (or if) I should continue with this. I get adding a ton of mimetype icons can be a headache for upkeep and everything and may go against the simplicity ethos so I don't want to throw stuff in that will complicate things. Just let me know. Thanks! |
Closing unless I get any feedback/suggestion to move forward. |
I'd like to add missing comic book and possibly other ebook mimetype icons. I'd really appreciate input/direction.
Currently this is what I have as the comic book icon:
(left current epub/ebook, right proposed comic book icon)
Just a slight modification of the eBook icon. Does
?!
work or should those symbols be reserved for dialog icons? Is it too silly looking compared to the more serious/professional look of the rest of the icons?A few other eBook icons are also missing. Here is a list and proposals.
.azw
,.azw3
,.mobi
) -> symlink to epub/ebook icon.djvu
) - > symlink to pdf icon, this is a scanned document format like pdf or ps.ps
) -> symlink to pdf (edocument instead of ebook but just noticed it is missing)Also, the FB2 icon is missing at 128px. I can add this but before I do -- should I keep the orange look and the
fb
lettering? Or switch to the green (and possibly the e of the epub/ebook) so all ebook file icons consistent?Fixes #1075
Addresses part of issue #548
Thanks!