Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update eBook and eDocument mimetype icons #1079

Closed

Conversation

newhoa
Copy link
Collaborator

@newhoa newhoa commented Jan 27, 2022

I'd like to add missing comic book and possibly other ebook mimetype icons. I'd really appreciate input/direction.

Currently this is what I have as the comic book icon:
(left current epub/ebook, right proposed comic book icon)

comic-icon-rc

Just a slight modification of the eBook icon. Does ?! work or should those symbols be reserved for dialog icons? Is it too silly looking compared to the more serious/professional look of the rest of the icons?

A few other eBook icons are also missing. Here is a list and proposals.

  • Amazon eBook and Mobipocket icons (.azw, .azw3, .mobi) -> symlink to epub/ebook icon
  • Deja Vu (.djvu) - > symlink to pdf icon, this is a scanned document format like pdf or ps
  • PostScript (.ps) -> symlink to pdf (edocument instead of ebook but just noticed it is missing)

Also, the FB2 icon is missing at 128px. I can add this but before I do -- should I keep the orange look and the fb lettering? Or switch to the green (and possibly the e of the epub/ebook) so all ebook file icons consistent?

comic-icon-fb2

Fixes #1075
Addresses part of issue #548

Thanks!

@waldyrious
Copy link
Contributor

Amazon eBook and Mobipocket icons (.azw, .azw3, .mobi) -> symlink to epub/ebook icon

Since .epub is a specific format (and the icon in the epub/ebook icon is the EPUB symbol), IMHO there should be a generic ebook icon that doesn't use any specific symbol/logo.

- Comic Book icon (.cbz, .cbr)
- Mobipocket icon (.mobi, .azw, .azw3)
- Postscript icon (.ps)
- Deja Vu icon (.djvu)
@newhoa newhoa force-pushed the issue-1075-ebook-mimetype-update branch from b3c4f8e to 2cc0835 Compare January 30, 2022 04:39
@newhoa
Copy link
Collaborator Author

newhoa commented Jan 30, 2022

Amazon eBook and Mobipocket icons (.azw, .azw3, .mobi) -> symlink to epub/ebook icon

Since .epub is a specific format (and the icon in the epub/ebook icon is the EPUB symbol), IMHO there should be a generic ebook icon that doesn't use any specific symbol/logo.

Makes sense, thanks! Ok, I updated. Currently:

  • Comic icon (.cbz, .cbr) eBook -> eBook with ?! speech bubble
  • Amazon and Mobipocket eBook (.azw, .azw3, .mobi) -> generic eBook icon
  • Deja Vu (.djvu) eDocument - > symlink to pdf icon
  • PostScript (.ps) eDocument -> symlink to pdf icon
  • Fictionbook (.fb2) eBook -> added 128px icon, propose making it green to match other eBooks

For Mobipocket/Amazon, currently using blank green book/ebook icon (right), could try adding text or a bookmark (left), but bookmark may make it feel like a bookmark file. So might be best to leave it blank/generic unless someone can suggest something that symbolizes Amazon/Mobi (can't use their logo of course).
e-icon-book-generic

Edit: I also tried generic eBook with the pdf e symbol, but I wasn't sure if that was for "electronic" or "evince". If evince, it wouldn't make sense because while evince reads DejaVu and PostScript, it does not read any of the Amazon/Mobi eBook formats.
e-icon-book-generic-e

FictionBook/fb icon, added 128px. I like the green better, matches the other eBooks if the above changes go through. If green is preferred I can change the other sizes as well.
e-icon-fb

Any more input would be helpful. Thanks!

@newhoa newhoa changed the title Add comic book, other missing ebook mimetype icons Add/update eBook and eDocument mimetype icons Jan 30, 2022
@danirabbit
Copy link
Member

Hey thanks for looking into this!

I would lean away from changing the file type icons for any formats that aren't supported out of the box. It's pretty easy for file types to get out of control trying to support absolutely every format, so we've really been slimming these down. Anything in the application-x-* namespace should technically be handled by those applications when they're installed, so we should avoid touching those if possible.

In fact, it would be worth probably dropping some of the filetype icons in the current master. I would be inclined to remove the fictionbook icons tbh. But if it stays, the fictionbook icon should remain orange since that's the brand color used in the fictionbook logo.

Something we should test is if fallbacks in the namespace work for these +zip etc names. For example, instead of symlinking application-vnd.comicbook+zip and application-vnd.comicbook-rar, you might be able to do application-vnd.comicbook and we should fall back correctly there to the less specific namespace

For the comicbook icon I like the metaphor, but I might try to re-use the bubble shape from internet-chat in apps. And for the text it would probably help for hinting not to use italic and use Inter Bold as the typeface

@newhoa
Copy link
Collaborator Author

newhoa commented Feb 7, 2022

@danrabbit, What would you suggest about the other eDocument/eBook mimetypes in this PR. DejaVu and PostScript are both read by Evince. Is using the pdf/eDocument icon okay for those? Mobi/AZW are not read by default (but neither is ePub). Use the generic eBook icon or don't worry about those?

Anything in the application-x-* namespace should technically be handled by those applications when they're installed...

Is this an elementary convention or a standard for mimetypes? I don't know much about the naming scheme of mimetypes and the reasoning behind some of them. I've noticed some mimetype icons are provided by an app if it can only be opened with that app, application-x-ardour for example. But then you have a format like tar which uses application-x-tar which no app seems to provide an icon for and can be opened by many apps. That's an old format but there are a lot of modern ones to which the same applies, or for which the official app is not available on Linux though the format can be read by plenty of other apps. And unfortunately when files don't have icons or have incorrect icons, to the end user who doesn't know the reasoning, it feels a little incomplete or the fault of the system/theme.

For the comic icon, I tried using the name application-vnd.comicbook and it did not seem to work. That would've been really nice.

I tried this version with the internet-chat icon (with and without outline):
e-icon-book-chat-inter

I also tried an outline on the first version. However, the ePub e which it is based off of (and FictionBook fb) does not have a border so it isn't very consistent.
e-icon-book-comic-outline

Personally I feel the chat bubble should be reserved for chat related icons (as it is also used for the Iridium app icon which could be confusing). Usually comic bubbles have a longer sharper tail. And the font is usually somewhat italic, with question and exclamation marks usually being bold and more italicized. Here's an example. That was kind of my rationale for the original icon. With the chat bubble and normal font it looks a little like a chat or help symbol to me. But I've been playing with it too long so my perspective might be way off.

Anyway, just let me know how (or if) I should continue with this. I get adding a ton of mimetype icons can be a headache for upkeep and everything and may go against the simplicity ethos so I don't want to throw stuff in that will complicate things. Just let me know. Thanks!

@newhoa
Copy link
Collaborator Author

newhoa commented Jun 26, 2022

Closing unless I get any feedback/suggestion to move forward.

@newhoa newhoa closed this Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing comic book mimetype icons
3 participants