Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding Inherits=hicolor to the index.theme file #1236

Closed
milouse opened this issue Dec 6, 2023 · 2 comments
Closed

Consider adding Inherits=hicolor to the index.theme file #1236

milouse opened this issue Dec 6, 2023 · 2 comments

Comments

@milouse
Copy link

milouse commented Dec 6, 2023

What Happened?

When using elementary icons theme, some application (like fuzzel) are not able to "fallback" on something when an icon is missing from the theme. On the other hand, a lot of third party application install their icon in the hicolor theme in order for them to be available.

I’m don’t know if this is a deliberate choice or not? And whether this is an error of the theme or if all applications are expected to do the fallback by themselves?

Adwaita theme for exemple does include this fallback.

If you confirm this is not a choice, I’m willing to post the fixing MR if you wish.

Steps to Reproduce

fuzzel --icon-theme elementary

capture_without

Expected Behavior

capture_with

OS Version

Other Linux

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@newhoa
Copy link
Collaborator

newhoa commented Jun 2, 2024

I think this might actually be an issue with the app, not the icon theme.

According to the FD.o Icon Theme Spec:

Implementations are required to look in the "hicolor" theme if an icon was not found in the current theme.

And in the Standard Keys section (Table 1), Inherits is not a required key (and hicolor should be checked whether the Inherits line exists or not), noting:

If no theme is specified implementations are required to add the "hicolor" theme to the inheritance tree. An implementation may optionally add other default themes in between the last specified theme and the hicolor theme.

So it seems fuzzel should add hicolor to their icon lookup as a final fallback, even if it's not in the Inherits line.

@milouse
Copy link
Author

milouse commented Jun 4, 2024

Thank you very much for your answer. I’ll try to contact fuzzel maintener with a patch for it.

@milouse milouse closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants