Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use 'Capture' verb #196

Closed
wants to merge 7 commits into from
Closed

Conversation

cassidyjames
Copy link
Contributor

Intends to fix #195. Open to discussion.

@cassidyjames cassidyjames requested a review from a team November 3, 2020 19:07
@danirabbit
Copy link
Member

Hrrmmmm I haven't pulled this yet but my first couple of thoughts are:

Having capture in every label in the UI seems bad. I feel like it's generally not good to be too repetitive, especially when trying to show the differences between options

"Capture screenshot of the whole screen" doesn't seem better than "Screenshot the whole screen"

Perhaps we should lean towards just using "screenshot" as a verb where it makes sense. Our window menu label could be "Screenshot This Window" and that seems pretty clear without being overly verbose

Reading it back, I also feel like both "Grab pointer" and "Capture pointer" are probably less clear than "Include pointer"

@fabiozaramella
Copy link
Member

fabiozaramella commented Nov 3, 2020

Having capture in every label in the UI seems bad. I feel like it's generally not good to be too repetitive, especially when trying to show the differences between options

I agree, it would end up being repetitive.

Perhaps we should lean towards just using "screenshot" as a verb where it makes sense. Our window menu label could be "Screenshot This Window" and that seems pretty clear without being overly verbose

I think it's better to avoid using nouns as verbs when possible, especially when terms like this are not really translatable into other languages. For example "Grab this Window" is translated in italian as "Cattura questa finestra" whereas "Screenshot this Window" can't be translated properly. I mean, we can keep the same translation of course but my concern is that some other new translators (or in other languages) may translate it improperly for example using the slang "Screenshottare" (to take a screenshot) in the italian case.
What I'm trying to say is that verbs like "grab" have corresponding verbs in other languages whereas IT terms like "screenshot" may not always have one and/or feel out of place.

Reading it back, I also feel like both "Grab pointer" and "Capture pointer" are probably less clear than "Include pointer"

I also agree that "Include pointer" is better.

@cassidyjames
Copy link
Contributor Author

Yeah being repetitive is a problem. But before we were using at least 3 different verbs, so I think we should align on what verb we use in general for taking screenshots and use that consistently. At the same time, we should work to reduce repetitiveness.

We should probably have the app name in the Actions results anyway, so this should be able to be less redundant. See: elementary/applications-menu#277
@cassidyjames
Copy link
Contributor Author

Okay I like this more. It's more concise in general and should address what you both brought up. Now I guess, do we like "Capture" or "Take" better? Regarding .desktop action names, see: elementary/applications-menu#277 as I think that will also make this work better, as with other apps.

Copy link
Member

@fabiozaramella fabiozaramella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in the UX team and I still want to hear from it but is an approval from me 👍🏻

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple inline comments.

Have you tested that actions still appear when searching for "Screenshot" even if their text doesn't contain that word?

src/ScreenshotWindow.vala Outdated Show resolved Hide resolved
data/screenshot.desktop.in Outdated Show resolved Hide resolved
@danirabbit
Copy link
Member

This hasn't moved in a month so I'm gonna kick it to a draft

@danirabbit danirabbit marked this pull request as draft December 22, 2020 19:12
@cassidyjames
Copy link
Contributor Author

@danrabbit couple of comments addressed.

Have you tested that actions still appear when searching for "Screenshot" even if their text doesn't contain that word?

As mentioned in #196 (comment):

Regarding .desktop action names, see: elementary/applications-menu#277 as I think that will also make this work better, as with other apps.

Do you consider that a blocker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More consistent terminology
3 participants