Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot be packaged as a flatpak due to theme name containing . #1072

Open
TingPing opened this issue Aug 11, 2021 · 4 comments
Open

Cannot be packaged as a flatpak due to theme name containing . #1072

TingPing opened this issue Aug 11, 2021 · 4 comments

Comments

@TingPing
Copy link

TingPing commented Aug 11, 2021

The current theme names are ID style (io.elementary.stylesheet.banana).

However the way Flatpak does themes is it uses extension points, and extension points match by . separators.

So org.gtk.Gtk3theme.theme-name means theme-name is an extension to org.gtk.Gtk3theme.

org.gtk.Gtk3theme.io.elementary.stylesheet.banana means banana is an extension to org.gtk.Gtk3theme.io.elementary.stylesheet which will fail and not be useful.

AFAICT you cannot explicitly set an extension point name separate from the ID but I might be missing something there.

Two potential paths forward:

  • Change flatpak to support remaping another character to ., like _ or -.
    The downside here is that change will take a long time to make it to users.

  • Rename the theme upstream to be more accommodating.

@cassidyjames
Copy link
Contributor

cassidyjames commented Aug 11, 2021

Note that we can't easily change the theme names now that OS 6 has been released; it would require changing several components that use the theme names as well as changing the user's current settings out from under them and that sounds like a huge potential for breakage. So at the earliest this could be fixed from our side for OS 7.

@cassidyjames
Copy link
Contributor

And as a note, our recommendation to Flatpak app authors that have tested their apps against the elementary stylesheet and want it to be used on elementary OS is that they opt into using it by either using the elementary Platform (as required in the AppCenter remote) or by bundling the stylesheet (as I believe Epiphany does?).

@TingPing

This comment has been minimized.

@OssNass

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants