Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3× scaling setting #130

Closed
cassidyjames opened this issue Oct 10, 2018 · 12 comments
Closed

Add 3× scaling setting #130

cassidyjames opened this issue Oct 10, 2018 · 12 comments
Assignees
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Needs Design Waiting for input from the UX team Priority: Low On the radar, but not the most urgent thing

Comments

@cassidyjames
Copy link
Contributor

cassidyjames commented Oct 10, 2018

Modern hardware is cropping up where 3× scaling might make sense. We should probably go ahead and add it to the scaling factor combobox.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@cassidyjames cassidyjames added the Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. label Oct 10, 2018
@cassidyjames cassidyjames self-assigned this Oct 10, 2018
@cassidyjames cassidyjames added the Needs Design Waiting for input from the UX team label Oct 10, 2018
@cassidyjames
Copy link
Contributor Author

Trying to think of the right UI copy for this. Right now we have three options:

  • Automatic
  • LoDPI
  • Pixel Doubled

"Pixel Tripled" sounds weird, and I think it'd make more sense to break into 3× at that point. Do we do something like this?

  • Automatic
  • LoDPI (1×)
  • HiDPI (2×)
  • HiDPI (3×)

Or is having the scaling factor listed there a little weird?

@jlnr
Copy link
Member

jlnr commented Oct 10, 2018

Assuming that users will change this setting because things are too small/large on their screen, I think "Zoom: 100% / 200% / 300%" is easier to understand.

Since any change here requires a reboot, it would also be nice if "Automatic" was more specific ("Automatic (200%)") so that users don't change it from "Automatic" to e.g. 200%, only to discover that everything looks the same after a reboot.

@cassidyjames
Copy link
Contributor Author

cassidyjames commented Oct 10, 2018

@jlnr I think "zoom" is probably abstracting/papering over it a bit too much. Some users will be familiar with scaling factors, and 1x/2x/3x is a common way to denote that. Whereas "Zoom" could be font zoom, the existing zoom functionality, or something new altogether. And for the vast majority of people, Automatic should be the correct setting, and we'd rather they use something less drastic like text size if they need things to be a bit bigger.

But I do think you raise a good point about "automatic" having the scaling factor listed.

Scaling factor:

  • Automatic (2×)
  • LoDPI (1×)
  • HiDPI (2×)
  • HiDPI (3×)

Is "force" too… forceful?

Scaling factor:

  • Automatic (2×)
  • Force LoDPI (1×)
  • Force HiDPI (2×)
  • Force HiDPI (3×)

@cassidyjames
Copy link
Contributor Author

And I guess for completeness, here's the smallest diff, but I don't like it:

Scaling factor:

  • Automatic
  • LoDPI
  • Pixel Doubled
  • 3× Scaling (or something)

@steakscience
Copy link

  • Automatic
  • LoDPI (1×)
  • HiDPI (2×)
  • HiDPI (3×)

This is a good solution @cassidyjames

@cassidyjames cassidyjames added the Priority: Low On the radar, but not the most urgent thing label Oct 24, 2018
@matej-marcisovsky
Copy link

What about this:

  • Automatic
  • LoDPI
  • HiDPI
  • HiDPI+

Scaling factor is weird and kinda useless for regular users. As a user you have to think about what the number in parenthesis is representing - scale, zoom, three times what?

@cassidyjames
Copy link
Contributor Author

HiDPI+ isn't an industry standard term at all, though. I think in this case I'd like to be more honest/up-front about the scaling factor. We'd also label the dropdown as "Scaling factor" still.

@jlnr
Copy link
Member

jlnr commented Feb 22, 2019

To add one more objection, LoDPI is not an industry standard term either, and I think it sounds too negative. There's nothing wrong with 1440p at 27", or 1080p/1200p at 24". I don't have a good suggestion for an alternative, though. (Percentages ftw 😬)

@tintou
Copy link
Member

tintou commented Feb 22, 2019

Scaling factor:
Btw, we don't have to hardcode the max number anymore, we can just get that number from Mutter (this combobox predates Mutter support)

@cassidyjames
Copy link
Contributor Author

@tintou I would like to distinguish between loDPI and HiDPI since those are terms we use when talking about elementary OS, and at the very least if someone doesn't understand scaling factors, that's another possibly-familiar term they could recognize.

@matej-marcisovsky
Copy link

What about scaling factor as number input/slider with a hint text? If user slides the scale factor to 2x hint text shows up telling him that this is a good value for HiDPI monitors etc.

@cassidyjames
Copy link
Contributor Author

Fixed in the simplest case by #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Small, self-contained issue. Good for newcomers, and/or should be an easy fix. Needs Design Waiting for input from the UX team Priority: Low On the radar, but not the most urgent thing
Projects
None yet
Development

No branches or pull requests

5 participants