Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled List: Fix has-due? and has-start? #149

Open
marbetschar opened this issue Oct 9, 2020 · 4 comments
Open

Scheduled List: Fix has-due? and has-start? #149

marbetschar opened this issue Oct 9, 2020 · 4 comments
Labels

Comments

@marbetschar
Copy link
Member

As EDS added support for has-end?, has-due? and has-duration? in 3.39.1+, we should also fix our s-expression for the Scheduled List in MainWindow.vala:

var query = "AND (NOT is-completed?) (OR (has-start?) (has-alarms?))";

According to RFC554, either dtstart or due can be set - so our s-expression should be changed to:

var query = "AND (NOT is-completed?) (OR (has-start?) (has-due?))";

@danrabbit will Evolution Data Server 3.39.1+ eventually land in Odin?

@marbetschar
Copy link
Member Author

Sidenote: Whether EDS lands in Odin or not, in every case we want to remove has-alarms? from the s-expression - #147 does take care of this.

@marbetschar marbetschar changed the title Scheduled List: Fix for S-Expression Scheduled List: Fix has-due? and has-start? Oct 9, 2020
@danirabbit
Copy link
Member

@marbetschar at this point we're past the freeze in Ubuntu, so we'd have to backport it ourselves. It looks like we're currently on 3.36.4. My assumption would be that we wouldn't normally backport something like EDS because Canonical maintains security patches for what's in their repos, but @tintou would have more of an opinion on this

@marbetschar
Copy link
Member Author

iOS Reminders sets both properties (start and due), so I guess we are fine if we do the same. Then we can simply query for (has-start?). The needed changes for this to work is implemented in #147.

Although I don't know about other Task/Reminder Apps. I guess the most interesting part here would be to know how a broadly used one on Android behaves (I guess thats Tasks) to figure out if we are on the right track here.

@tintou
Copy link
Member

tintou commented Oct 12, 2020

I would indeed avoid as much backport as we can as it would mean that we have to support it for 3 years ourselves…
We will be flatpak-native at some point which would simplify issues like this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants