Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown players fall back to Music icon #197

Closed
danirabbit opened this issue Apr 13, 2021 · 0 comments · Fixed by #198
Closed

Unknown players fall back to Music icon #197

danirabbit opened this issue Apr 13, 2021 · 0 comments · Fixed by #198
Labels
Good First Issue Priority: Low Status: Confirmed

Comments

@danirabbit
Copy link
Member

What Happened

If a player appears which we can't identify (such as from Chromium), it gets the Music icon as a fallback.

Expected Behavior

If we can't identify the app, it should get the application-default-icon, not the Music icon. We should only use the music icon when we know the audio is coming from Music.

Steps to Reproduce

  1. Watch a YouTube video with Chromium
  2. Notice the playback info is shown with the music icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Priority: Low Status: Confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fallback to application-default-icon elementary/wingpanel-indicator-sound
2 participants
@cassidyjames @danirabbit