Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue: Lints #58

Open
4 of 16 tasks
elenakrittik opened this issue Apr 25, 2024 · 0 comments
Open
4 of 16 tasks

Tracking Issue: Lints #58

elenakrittik opened this issue Apr 25, 2024 · 0 comments
Labels
a: parity Area: Feature parity with Godot and other tools c: gdtk-lint Crate: gdtk-lint issue: feature Feature request

Comments

@elenakrittik
Copy link
Owner

elenakrittik commented Apr 25, 2024

This issue tracks progress on implementing various rules, including those found in Godot itself as well as in senior gdtk. Feel free to point out missing rules by opening a new issue that mentions this one.

Rules

  • duplicated-load - Duplicated load()/preload().
  • standalone-expression - Standalone expressions are a no-op.
  • unnecessary-pass - There are other expressions in this block.
  • identifier-case - This identifier is incorrectly cased.
  • unused-item - This item is unused.
  • constant-expression-in-if - This if/elif's expression is constant.
  • private-member-access - This member is not part of its type's public API.
  • class-definitions-order - Statements in this file are unordered.
  • complexity - This item is too complex.
  • trailing-whitespace - Trailing whitespace found.
  • unnecessary-branch - This elif/else's if counterpart always returns. feat(gdtk-lint): unnecessary-branch #69
  • untyped-code - [HCS] Something that can have a static type does not.
  • nested-getnode - [HCS] Deeply nested paths in get_node or $ (use % instead).
  • unreachable-code - [INJ] self-explanatory.
  • dynamic-scenes - [IDX] Detected a dynamically-constructed scene. Creating scenes on-the-fly seriously harms the performance of your project; consider refactoring your project's structure to minimally rely on dynamic scene instantiations.
  • invalid_identifier - _ is not a valid identifier.
@elenakrittik elenakrittik added issue: feature Feature request c: gdtk-lint Crate: gdtk-lint a: parity Area: Feature parity with Godot and other tools labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: parity Area: Feature parity with Godot and other tools c: gdtk-lint Crate: gdtk-lint issue: feature Feature request
Projects
None yet
Development

No branches or pull requests

1 participant