Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: MSRV? #1

Open
maflcko opened this issue Jan 26, 2023 · 5 comments
Open

doc: MSRV? #1

maflcko opened this issue Jan 26, 2023 · 5 comments

Comments

@maflcko
Copy link

maflcko commented Jan 26, 2023

Just wondering if there is a minimum supported version and if it can be documented

@maflcko
Copy link
Author

maflcko commented Jan 26, 2023

Ah, found it 😅

//! Currently this library requires rust *nightly* for the `pin` macro, the `join` macro(used in tests) and the `const_waker` feature (required for complete optimization of `block_on`)

@elichai
Copy link
Owner

elichai commented Jan 27, 2023

Hehe yeah, everything here is ~1.36 but the compiler optimizations are much less effective if I don't make the Waker a const, and that requires either nightly (because Waker::from_raw is const unstable) or relying on implementation details and transmuting the RawWaker to a Waker

@elichai
Copy link
Owner

elichai commented Jan 27, 2023

I also hope that by me using nightly for these things it could hopefully help to push them for being stable sooner :)

@maflcko
Copy link
Author

maflcko commented Mar 10, 2023

@elichai
Copy link
Owner

elichai commented May 17, 2023

Fixed by https://blog.rust-lang.org/2023/03/09/Rust-1.68.0.html#local-pin-construction ?

Almost, I still need const_waker for optimal performance, might be able to simulate it with some unsafe
rust-lang/rust#102012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants