Skip to content
This repository has been archived by the owner on Oct 22, 2020. It is now read-only.

Bunyan can not be supported in Node versions > 8.9.1 (119) #83

Closed
g-sam opened this issue Apr 10, 2018 · 0 comments
Closed

Bunyan can not be supported in Node versions > 8.9.1 (119) #83

g-sam opened this issue Apr 10, 2018 · 0 comments

Comments

@g-sam
Copy link
Contributor

g-sam commented Apr 10, 2018

As described in nodejs/node#16949 (comment) since node-config does a deep clone of the config object, if bunyan is the configured logger, it leads to access of e.g. _handle.__proto__.bytesRead which, depending on your Node version, returns undefined (8.8.1 and lower), segfaults (8.9 and higher) or throws (8.9.2 and higher).

This doesn't happen with winston as the configured logger, so it's possible that bunyan could do something about the way they expose/not expose stdout/stdin in the exported object. Opened an issue at bunyan HQ: trentm/node-bunyan#571

More information here:
nodejs/node#17636
nodejs/node#16482
nodejs/node#16860

Tracking: https://gitlab.coko.foundation/pubsweet/pubsweet/issues/119

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants