fix(task): fix flawed validation

eliranmal · Sep 28, 2016 · 6a252d8 · 6a252d8
1 parent a0f1710
commit 6a252d8
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/tasks/sass-replace.js b/tasks/sass-replace.js
@@ -65,13 +65,17 @@ module.exports = function (grunt) {
     });
 
     function validate(value, invalidMessage, validMessage) {
-        var result = !util.isEmpty(value);
-        if (result) {
-            grunt.fail.warn(invalidMessage);
-        } else if (validMessage) {
-            grunt.log.ok(validMessage);
+        var isValid = !util.isEmpty(value);
+        if (isValid) {
+            if (validMessage) {
+                grunt.log.ok(validMessage);
+            }
+        } else {
+            if (invalidMessage) {
+                grunt.fail.warn(invalidMessage);
+            }
         }
-        return result;
+        return isValid;
     }
 
 };