Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revist the names of DataFrame.arrange/2 and DataFrame.arrange_with/2 #766

Closed
billylanchantin opened this issue Dec 11, 2023 · 3 comments
Closed

Comments

@billylanchantin
Copy link
Contributor

There's been some discussion of renaming the arrange functions to sort. E.g. here:

This would align better with the Series function names. Plus, the arrange names come from R where they were chosen to avoid namespace conflicts. We don't have to worry about that here.

However, this would be a breaking change. This issue is to hash out that discussion.

@josevalim
Copy link
Member

I am happy to roll with sort_by and sort_with. We should keep arrange and arrange_with around with @deprecated "foobar" annotations. They can simply delegate to the new sort_by and sort_with.

@cigrainger
Copy link
Member

Yep agreed!

@billylanchantin
Copy link
Contributor Author

Closed by: #777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants