Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run benchmarks? #268

Open
DaniruKun opened this issue Aug 26, 2022 · 2 comments
Open

How to run benchmarks? #268

DaniruKun opened this issue Aug 26, 2022 · 2 comments
Labels

Comments

@DaniruKun
Copy link

Describe the question
I have tried following the exact instructions in the benchmarks subdirectory, but running the tests always fails.
Could you please provide up-to-date instructions on how to setup an environment for benchmarks?

Versions:

  • OS: macOS 12.5 21G72 x86_64
  • Erlang:Erlang/OTP 25 [erts-13.0.3] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns]

Elixir 1.13.3 (compiled with Erlang/OTP 25)

  • Elixir:
  • mix.lock(grpc, gun, cowboy, cowlib):
@polvalente
Copy link
Contributor

I think we're gonna need @tony612's input here. The fork is based on a really outdated version of grpc, and what fails (at least for me) is some part of the build process. There aren't many additions, but we need a commit updating the fork.

Additions in question: grpc/grpc@master...tony612:grpc:elixir-bench

Alternatively, we could find a way to call the benchmark as a library instead and have this custom code as part of this repo.

@tony612
Copy link
Collaborator

tony612 commented Aug 31, 2022

grpc's benchmark is complex and it may change as time goes by, so it's not strange to see the failing. I think we need to revisit the benchmarks and lots of code may need to be changed. It will be better if we can find a way to not fork grpc/grpc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants