Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gun messages are not handled by GRPC library #340

Open
davydog187 opened this issue Nov 27, 2023 · 1 comment
Open

Gun messages are not handled by GRPC library #340

davydog187 opened this issue Nov 27, 2023 · 1 comment
Labels
bug

Comments

@davydog187
Copy link
Collaborator

Describe the bug
When connected to a GRPC service as a client, if that service goes down, or the connection is otherwise lost, :gun_down and :gun_up messages will be received from the calling process.

This behavior is a bit unexpected as Gun is an implementation detail of the library, and no where is it documented that these messages should be handled by the consumer of this library

To Reproduce
Steps to reproduce the behavior:

  1. Start a GRPC service
  2. Connect to it with this library
  3. Kill the GRPC service
  4. Observe that :gun_down message is received by the client

Expected behavior
Adapter lifecycle messages are abstracted by the library
@davydog187 davydog187 added the bug label Nov 27, 2023
@mickel8
Copy link

mickel8 commented Nov 27, 2023

Sounds like a duplicate of #337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davydog187 @mickel8