Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added font-lock to defoverridable #268

Merged

Conversation

gausby
Copy link
Contributor

@gausby gausby commented Oct 15, 2015

defoverridable didn't seem to get syntax highlighting. I've added it to the font-lock-keyword-face to it.

Before:
before

After:
after

I've done my best to add a unit-test. I am pretty new to this smie/font-lock stuff, so someone please review my code. Thanks.

@@ -108,6 +108,7 @@
("defp" non-block-expr "do" statements "end")
("defmacro" non-block-expr "do" statements "end")
("defmacrop" non-block-expr "do" statements "end")
("defoverridable" non-block-expr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is no need to add a rules for it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I just removed it and force pushed it on-top of my branch.

@tonini
Copy link
Contributor

tonini commented Oct 15, 2015

Great! 👍 I would like to merge this on. :) Just update the branch with the removed rule and we're good to go.

@gausby gausby force-pushed the add-font-lock-to-defoverridable branch from 6fa370b to ce94977 Compare October 15, 2015 11:45
tonini added a commit that referenced this pull request Oct 15, 2015
@tonini tonini merged commit e11c403 into elixir-editors:master Oct 15, 2015
@tonini
Copy link
Contributor

tonini commented Oct 15, 2015

Thanks @gausby! ❤️

@gausby gausby deleted the add-font-lock-to-defoverridable branch October 15, 2015 11:56
J3RN pushed a commit to J3RN/emacs-elixir that referenced this pull request Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants