Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary WINDOW_UPDATE frames in HTTP/2 client #432

Open
v0idpwn opened this issue Apr 29, 2024 · 1 comment
Open

Avoid unnecessary WINDOW_UPDATE frames in HTTP/2 client #432

v0idpwn opened this issue Apr 29, 2024 · 1 comment

Comments

@v0idpwn
Copy link
Contributor

v0idpwn commented Apr 29, 2024

In the current implementation, Mint automatically "refills" window sizes for both the stream and the connection whenever it receives data frames. This approach, while functional, leads to the generation of excess traffic due to frequent and possibly unnecessary WINDOW_UPDATE frames.

A more efficient approach is seen in :gun, which employs some heuristics to determine when sending WINDOW_UPDATE frames is actually needed. I suggest implementing a similar strategy in Mint as an optimization.

@whatyouhide
Copy link
Contributor

@v0idpwn sure we can do that. The HTTP/2 spec says to refill whenever you get data IIRC, but yeah we can try and be smarter. Wanna make a PR for this? I will not have time for a while and this is not high prio given everything technically works.

@whatyouhide whatyouhide changed the title Avoid unnecessary WINDOW_UPDATE frames in HTTP/2 client Avoid unnecessary WINDOW_UPDATE frames in HTTP/2 client Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants