Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning on Elixir 1.16 + OTP 25 #369

Closed
thbar opened this issue Mar 28, 2024 · 2 comments
Closed

Warning on Elixir 1.16 + OTP 25 #369

thbar opened this issue Mar 28, 2024 · 2 comments
Labels
Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work".

Comments

@thbar
Copy link

thbar commented Mar 28, 2024

Met this week while upgrading our main app:

==> protobuf
Compiling 37 files (.ex)
warning: pattern matching on 0.0 is equivalent to matching only on +0.0 from Erlang/OTP 27+. Instead you must match on +0.0 or -0.0
└─ lib/protobuf/encoder.ex: Protobuf.Encoder.skip_field?/3

Generated protobuf app

defp skip_field?(:proto3, 0.0, %FieldProps{oneof: nil}), do: true

@whatyouhide whatyouhide added the Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work". label May 11, 2024
@v0idpwn
Copy link
Collaborator

v0idpwn commented May 20, 2024

This should be closed per #370

@whatyouhide whatyouhide closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
@whatyouhide
Copy link
Collaborator

Yep this is fixed on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Bug A bug. Can be a documentation bug, Dialyzer issue, or anything that just "doesn't work".
Projects
None yet
Development

No branches or pull requests

3 participants