Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Function Clause with 0.24.0 and Chrome[driver] 83 #533

Closed
aj-foster opened this issue May 21, 2020 · 6 comments
Closed

No Function Clause with 0.24.0 and Chrome[driver] 83 #533

aj-foster opened this issue May 21, 2020 · 6 comments
Labels

Comments

@aj-foster
Copy link

Issue

After upgrading versions of Wallaby and Chromedriver, we recently started encountering an error in all of our Wallaby tests. The full stack trace is below. It appears there's a mismatch in the expectation of a port_number vs. wrapper_script_port field in the state passed to handle_info.

erlang 22.1.8
elixir 1.9.1
wallaby 0.24.0
chromedriver 83.0.0

Test Code & HTML

(This happens with all of our tests.)

13:46:22.106 [error] GenServer Wallaby.Experimental.Chrome.Chromedriver terminating
** (FunctionClauseError) no function clause matching in Wallaby.Experimental.Chrome.Chromedriver.Server.handle_info/2
    (wallaby) lib/wallaby/experimental/chrome/chromedriver/server.ex:76: Wallaby.Experimental.Chrome.Chromedriver.Server.handle_info({#Port<0.50>, {:data, "ChromeDriver was started successfully.\n"}}, %Wallaby.Experimental.Chrome.Chromedriver.Server.State{calls_awaiting_readiness: [], chromedriver_path: "/Users/linsy/Documents/lab-tools/client/node_modules/chromedriver/lib/chromedriver/chromedriver", port_number: 55959, ready?: false})
    (stdlib) gen_server.erl:637: :gen_server.try_dispatch/4
    (stdlib) gen_server.erl:711: :gen_server.handle_msg/6
    (stdlib) proc_lib.erl:249: :proc_lib.init_p_do_apply/3
Last message: {#Port<0.50>, {:data, "ChromeDriver was started successfully.\n"}}

The result, during test run, is this:

     ** (exit) exited in: GenServer.call(Wallaby.Experimental.Chrome.Chromedriver, :wait_until_ready, 5000)
         ** (EXIT) no process: the process is not alive or there's no process currently associated with the given name, possibly because its application isn't started
@matthewjsloane

This comment has been minimized.

@mhanberg
Copy link
Member

Hi, thanks for the bug report, I'll look into this!

@mhanberg
Copy link
Member

I was able to reproduce this.

The test suite fails resoundingly with the latest ChromeDriver version on the v0.24.0 tag, but passes on master. I should be able to cut a release of what's on master.

@mhanberg
Copy link
Member

Fix released as v0.24.1. Thanks again for the report!

@aj-foster
Copy link
Author

Fast and fantastic work. Thank you!

@mhanberg
Copy link
Member

Credit goes to @aaronrenner 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants