Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Wallaby.Browser.sync_result from opaque to type #540

Merged

Conversation

TheFirstAvenger
Copy link
Contributor

Fixes #539.

Changes Wallaby.Browser.sync_result from @opaque to @type.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files          26       26           
  Lines         853      853           
=======================================
  Hits          791      791           
  Misses         62       62           
Flag Coverage Δ
#IntegrationTest 87.69% <ø> (-0.12%) ⬇️
#UnitTest 39.39% <ø> (ø)
Impacted Files Coverage Δ
lib/wallaby/browser.ex 93.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f615b7d...ed9c096. Read the comment docs.

@mhanberg
Copy link
Member

Thanks for the PR!

I am curious as to why dialyzer doesn't complain about this in the Wallaby codebase 🤔.

@TheFirstAvenger
Copy link
Contributor Author

I am curious as to why dialyzer doesn't complain about this in the Wallaby codebase 🤔.

From what I can see, assert_has is never called in compiled code in the Wallaby codebase, only in tests.

@mhanberg
Copy link
Member

Ohh, that makes sense!

@mhanberg
Copy link
Member

Do you mind also adding this change to the changelog?

@TheFirstAvenger
Copy link
Contributor Author

Do you mind also adding this change to the changelog?

Done

@mhanberg mhanberg merged commit 30c510b into elixir-wallaby:master Jun 17, 2020
@mhanberg
Copy link
Member

v0.26.1 has been released with this change.

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Attempted to pattern match against the internal structure of an opaque term"
3 participants