Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to set particle color via a "(setq ...)" option #8

Open
fxkrait opened this issue Apr 24, 2023 · 2 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fxkrait
Copy link

fxkrait commented Apr 24, 2023

Particle color is set to match text color:
image

I can set it to a custom color (in this case pink) via overriding:

(defun power-mode--foreground-color-before-point ()
  "medium orchid"
)

image

  • It would be cool if that was available as a configuration option, with a (setq ...).
    • (I'm not 100% sure how to implement that with the existing code (I guess there could be a if/else added to that function: add a user-settable color variable, if color variable non-nil (user set a color) use that setq'd value & early return/terminate, else implicit else to run existing the code path to determine color from buffer/frame using text color), and with my current level of knowledge/competency (and time), hence why there is no PR appearing from me as of now. But I might push something up in the future regarding this.).
@elizagamedev elizagamedev added enhancement New feature or request good first issue Good for newcomers labels May 15, 2023
@elizagamedev
Copy link
Owner

Good idea! Should be pretty quick to implement when I've got a moment.

@fxkrait
Copy link
Author

fxkrait commented May 28, 2023

Added a PR for this, here. Just an additional defcustom and if statement.

  • Behavior looks OK, per PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants