Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches: file edit VS file replace #3259

Open
emanuele45 opened this issue Nov 20, 2018 · 1 comment
Open

Patches: file edit VS file replace #3259

emanuele45 opened this issue Nov 20, 2018 · 1 comment
Labels
Milestone

Comments

@emanuele45
Copy link
Contributor

Since #3256 has been merged and we have a nice namespace, I was thinking to advance another proposal: from 2.0 onward, any time during a micro update there is a change in a file in the ElkArte directory, instead of supporting the standard patching, the files are just replaced.
This has two implications:

  1. much easier updates (well, once I rewrote the code to create the packages)
  2. any addon that modifies one of these files should be presented with a way to interact with them without having to edit.

1 it's relatively easy, 2 may require some more work.

But I think at this point it may be an interesting move.

Opinions?

@emanuele45 emanuele45 added this to the 2.0 milestone Nov 20, 2018
@Spuds
Copy link
Contributor

Spuds commented Nov 20, 2018

Maybe if an addon has to modify a core file we could provide a simple way to flag that activity in the db.
Then when a patch comes out we check that "list" and if a file we are going to replace has been altered by an addon the patch simply says that you need to uninstall addon xyz before you can upgrade ? Or use a file checksum which would also catch any hand editing.

Of course it would be nice to provide such flexibility that an edit is never needed, its just hard to envision all of the tweaks people do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants