Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout confirmation on no session token and redirects #3368

Open
Vekseid opened this issue Nov 11, 2019 · 2 comments
Open

Logout confirmation on no session token and redirects #3368

Vekseid opened this issue Nov 11, 2019 · 2 comments

Comments

@Vekseid
Copy link
Contributor

Vekseid commented Nov 11, 2019

Feature request for some nice compatibility with the MediaWiki extension I wrote. See @jdarwood007 's post here:

SimpleMachines/smf-mw-auth#11 (comment)

There are two separate issues that are occurring, because session data can no longer be communicated between Mediawiki and SMF/Elkarte.

The first is I can't pass a proper logout token. The easy solution here is that when someone visits action=logout, rather than throw a session verification failed error, instead ask them if they want to log out.

The more complicated issue is trying to provide redirects to the previous wiki page. I'm not sure if it is terribly worth it to give much thought to, but coming up with something might be a nice 2.0 feature.

@Spuds Spuds added this to the 2.0 milestone Nov 11, 2019
@Spuds
Copy link
Contributor

Spuds commented Nov 11, 2019

The logout confirmation w/o session makes a lot of sense and is easy to do. Not sure on how to best handle redirects between the two, but it would be nice to have.

@jdarwood007
Copy link

@Spuds If I get time this weekend, I was going to write up a solution for 2.1 as a PR. But looking quickly at Elkarte, I don't see the needed components. But the same idea could apply if you apply the similar idea. I've worked on changes to the base that @Vekseid wrote which is changing a bit of the extension but will work with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants