Do not attempt to read directory as file #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxim-Mazurok
changed the title
Splaktar
suggested changes
Jul 10, 2022
| @@ -191,7 +191,7 @@ export class AnalysisTool { | |||
| (filename: string, data: string) => this.checkFileForScriptingLanguage(filename, data), | |||
| (filename: string, data: string) => this.checkFileForComponent(filename, data), | |||
| ]; | |||
| if (currentPath.substr(-3) === '.js' || this.fileHasTsExtension(currentPath) || currentPath.substr(-5) === '.html' || currentPath.substr(-5) === '.json') { | |||
| if ((currentPath.substr(-3) === '.js' || this.fileHasTsExtension(currentPath) || currentPath.substr(-5) === '.html' || currentPath.substr(-5) === '.json') && fs.lstatSync(currentPath).isFile()) { | |||
There was a problem hiding this comment.
It seems like you would want this isFile() at a higher level so that it would apply whether the directory had .json or .html in it, basically it shouldn't check any of these file extensions unless it's dealing with a file.
There was a problem hiding this comment.
It sounds like an optimization, my solution worked for me allowing me to use the tool, so I decided to share. If you believe there's a better solution - please create a new PR, I don't use this tool anymore and didn't find it to be particularly helpful. Cheers!
There was a problem hiding this comment.
@Splaktar I wonder if you think it's ok to merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30