Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadMe still references elm-package.json and copying dependencies #19

Closed
Chadtech opened this issue Sep 1, 2018 · 5 comments
Closed
Labels
docs Documentation issues

Comments

@Chadtech
Copy link

Chadtech commented Sep 1, 2018

Hi,

The readme still talks about elm-package.json, even thought 0.19 uses elm.json files. And it still talks about copying dependencies between your main and test elm-package.json files, even though we can use one elm.json in 0.19

I would make the PR myself, but I am currently trying to figure out how to do tests with 0.19 myself, so I dont really know how to instruct others.

@mgold mgold added the docs Documentation issues label Sep 1, 2018
@rtfeldman
Copy link
Collaborator

Good point, thanks! It's on the list for rtfeldman/node-test-runner#265 to change the behavior of elm-test init to no longer attempt to copy dependencies, but 👍 to the need for a doc fix.

@agmenc
Copy link

agmenc commented Sep 2, 2018

@Chadtech Did you manage to figure out how to run tests in 0.19? I'm still stumped.

Whenever I run elm-test tests/Example.elm from my project's root directory, I get:

It looks like you're running elm-test from within your tests directory.
Please run elm-test from your project's root directory, where its elm-package.json lives!

I've followed the suggestions in this discourse post and taken the following steps:

  • Used elm-rosetree as a reference to copy from, because the author has upgraded to Elm 0.19, has tests and has a passing build.
  • Installed the latest elm-test beta npm install elm-test@0.19.0-beta4
  • Cleared existing builds rm -r elm-stuff
  • Run elm-test init. This doesn't really seem to be working well with Elm 0.19, because it is trying to use the elm-package command, which doesn't exist in 0.19.
  • Removed the extra elm-package.json installed in tests by elm-test init. The updated projects I used as references don't have elm-package.json or elm.json in their tests directory, so I figure it is no longer needed. Having it there made no difference, anyway.
  • I've tried creating a spurious (but correct) elm-package.json in my root directory, but I see the same error message.

I'd be grateful for any suggestions.

@Chadtech
Copy link
Author

Chadtech commented Sep 2, 2018

@agmenc When do you do elm-test --version what do you see? I kept getting the 0.18 version of elm-test when installing, even when installing elm-test@0.19.0-beta5. I really banged my head on the wall for a while (I think my npm is all messed up), so I dont know what exactly made the difference for me. What finally worked was just npm install -g elm-test@beta (or instead of beta the specific beta version). Maybe you have it installed globally and npm install elm-test@beta is only doing it locally, so your elm-test command is still globally tied to your old elm-test?

I'm Chadtech in the elm-slack, maybe we could continue the conversion in a DM there if you are also in the elm-slack.

@harrysarson
Copy link
Collaborator

Could this issue have been fixed? I see no mention of elm-package.json or copying dependencies in the readme?

@Chadtech
Copy link
Author

Looks like it @harrysarson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issues
Projects
None yet
Development

No branches or pull requests

5 participants