Skip to content
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.

npm installer should work with --ignore-scripts #205

Closed
rtfeldman opened this issue Apr 26, 2017 · 2 comments
Closed

npm installer should work with --ignore-scripts #205

rtfeldman opened this issue Apr 26, 2017 · 2 comments

Comments

@rtfeldman
Copy link

If you run npm install --ignore-scripts, the npm installers should still work.

This is possible if the default binaries change. Currently they pretty much echo "uh oh something went wrong!" because they were supposed to get overwritten by the downloaded ones.

What they can do instead is to attempt to download the actual binaries, install them, and then run them. This way, even if the post-install scripts didn't run, you will still "lazily" get the outcome you wanted. It's just that the first time you run elm-make it will be a tiny script that downloads the Elm Platform, installs it over the elm-make you ran, and then runs the real elm-make.

Running the elm-make script may mean that it's not possible to copy a new elm-make over the original while it's still running. If that's true, though, there may also be a way to do some careful process management to get around that. I'm not sure.

@process-bot
Copy link

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@evancz
Copy link
Contributor

evancz commented Feb 21, 2018

If you still want this open, please make a meta issue of anything you want to do with the npm installer. Or we should figure out some other way if that's not ideal for some reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants