Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run additional script during uninstall for VSCode to remove LS and files completely #216

Open
thadguidry opened this issue Oct 6, 2021 · 0 comments

Comments

@thadguidry
Copy link

Installation of elmtooling.elm-ls-vscode-xxx on VSCode puts most of it's files under a path of
<vscode>/data/extensions/.elmtooling.elm-ls-vscode-xxxx
and where after uninstalling the extension from VSCode that path and all files within is left untouched and should be removed completely.

Expected Behavior

In VSCode, clicking uninstall of the plugin(s) should completely remove files for language server (LS)

Current Behavior

After clicking uninstall, additional cleanup is not done to completely remove node remnants and files/dependencies under <vscode>/data/extensions/.elmtooling.elm-ls-vscode-xxxx

Possible Solution

It should be fairly trivial to run a node script and add this additional script to package.json manifest as documented by MS VSCode's Extension uninstall hook

{
  "scripts": {
    "vscode:uninstall": "npm run uninstall-cleanup"
  }
}

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used: .elmtooling.elm-ls-vscode-2.1.0
  • Editor used: VSCode Insiders latest
  • Environment name and version (e.g. node.js 5.4):
  • Operating System and version: Windows 10 Pro 10.0.19043
@razzeee razzeee transferred this issue from elm-tooling/elm-language-server Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant