Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not explained that pushUrl doesn't need whole URL to work #108

Open
ghost opened this issue Apr 6, 2020 · 0 comments
Open

Not explained that pushUrl doesn't need whole URL to work #108

ghost opened this issue Apr 6, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Apr 6, 2020

The docs don't explain that pushUrl will work with just the path onwards (so you don't need the whole URL). I had assumed "URL" meant the whole thing, protocol and hostname included, so I was making effort to pass that around my app so that pushUrl would have it where necessary. Of course, in hindsight, it makes perfect sense that pushUrl shouldn't have to deal with the domain, as that stays the same no matter what page you're on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants