Skip to content

Commit e1c5909

Browse files
Ganqxpm215
authored andcommitted
allwinner-a10-pit: Use ptimer_free() in the finalize function to avoid memleaks
When running device-introspect-test, a memory leak occurred in the a10_pit_init function, so use ptimer_free() in the finalize function to avoid it. ASAN shows memory leak stack: Indirect leak of 288 byte(s) in 6 object(s) allocated from: #0 0xffffab97e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0) #1 0xffffab256800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800) #2 0xaaabf555db84 in timer_new_full /qemu/include/qemu/timer.h:523 qemu#3 0xaaabf555db84 in timer_new /qemu/include/qemu/timer.h:544 qemu#4 0xaaabf555db84 in timer_new_ns /qemu/include/qemu/timer.h:562 qemu#5 0xaaabf555db84 in ptimer_init /qemu/hw/core/ptimer.c:433 qemu#6 0xaaabf57415e8 in a10_pit_init /qemu/hw/timer/allwinner-a10-pit.c:278 qemu#7 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 qemu#8 0xaaabf633ca04 in object_initialize_child_with_propsv /qemu/qom/object.c:564 qemu#9 0xaaabf633cc08 in object_initialize_child_with_props /qemu/qom/object.c:547 qemu#10 0xaaabf5b94680 in aw_a10_init /qemu/hw/arm/allwinner-a10.c:49 qemu#11 0xaaabf6339f6c in object_initialize_with_type /qemu/qom/object.c:515 qemu#12 0xaaabf633a1e0 in object_new_with_type /qemu/qom/object.c:729 Reported-by: Euler Robot <euler.robot@huawei.com> Signed-off-by: Gan Qixin <ganqixin@huawei.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
1 parent ea492b1 commit e1c5909

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

hw/timer/allwinner-a10-pit.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,16 @@ static void a10_pit_init(Object *obj)
279279
}
280280
}
281281

282+
static void a10_pit_finalize(Object *obj)
283+
{
284+
AwA10PITState *s = AW_A10_PIT(obj);
285+
int i;
286+
287+
for (i = 0; i < AW_A10_PIT_TIMER_NR; i++) {
288+
ptimer_free(s->timer[i]);
289+
}
290+
}
291+
282292
static void a10_pit_class_init(ObjectClass *klass, void *data)
283293
{
284294
DeviceClass *dc = DEVICE_CLASS(klass);
@@ -294,6 +304,7 @@ static const TypeInfo a10_pit_info = {
294304
.parent = TYPE_SYS_BUS_DEVICE,
295305
.instance_size = sizeof(AwA10PITState),
296306
.instance_init = a10_pit_init,
307+
.instance_finalize = a10_pit_finalize,
297308
.class_init = a10_pit_class_init,
298309
};
299310

0 commit comments

Comments
 (0)