New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F# 9 nullability migration #622

Open

xperiandri opened this issue Jan 8, 2025 · 0 comments

xperiandri commented Jan 8, 2025

High-level description
I've migrated my code to F# 9 compiler and nullability support

Expected or desired behavior
You can pick my changes if you want the same migration
Ecierge/Elmish.Uno#1

Additional Information
The other question is should we restrict a model and a message on a view model to be non-null?

type DynamicViewModel<'model, 'msg when 'model : not null and 'msg : not null>
      ( args: ViewModelArgs<'model, 'msg>,
        bindings: Binding<'model, 'msg> list)
type ViewModelBase<'model, 'msg when 'model : not null and 'msg : not null>(args: ViewModelArgs<'model, 'msg>)

https://github.com/Ecierge/Elmish.Uno/blob/be64c50b6b7cca1ac774704145e09fd17ee4cf3f/src/Elmish.Uno/ViewModels.fs#L143
https://github.com/Ecierge/Elmish.Uno/blob/be64c50b6b7cca1ac774704145e09fd17ee4cf3f/src/Elmish.Uno/ViewModels.fs#L359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment